fix(grep): return lines even in the presence of warnings #8310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
andrewphelpsj
force-pushed
the
grep-fix
branch
from
314aa54 to
bd4696f
Compare
Author
|
Closed by #8612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8307 by modifying the
Greptool so that an error is only returned ifripgrep's stdout is empty, in addition to checking the status code.This might not be the solution you all want, since it doesn't enable the model to get the potentially useful warning messages out of the tool call.
How did you verify your code works?
Added some unit tests, and recreated the scenario here: https://opncd.ai/share/9YARWprF. Create a broken symlink, and then ask the model to grep in the root of the repo.