feat: add interactive mode support for bash commands #8696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for interactive bash commands requiring user input (arrow keys, text entry, etc.) by leveraging the existing PTY infrastructure. - Add interactive parameter to bash tool with allowlist of supported commands - Create BashInteractive TUI component with WebSocket PTY connection - Implement retry logic with exponential backoff for connection failures - Add ESC key to exit interactive mode - Silent fallback to regular spawn for unsupported commands or PTY failures Fixes anomalyco#1180
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Process Tools for Interactive CLI commands This PR may be related as it also addresses interactive CLI command support, which appears to be in the same problem domain as PR #8696's interactive bash command feature. All other results were either the current PR (#8696) itself or unrelated PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1180
Summary
Adds support for interactive bash commands (like
opencode auth login,vim,ssh) by using the existing PTY infrastructure wheninteractive: trueis set.Changes
interactiveparameter to bash tool with allowlist of supported commandsBashInteractiveTUI component that connects to PTY via WebSocketHow it works
When
interactive: trueand command is in allowlist → creates PTY session → TUI component captures keyboard input and streams it to/from PTY. Everything else works exactly as before.Testing needed
opencode auth loginwith arrow keysvim test.txtworksls -lastill works (falls back to regular mode)Allowlisted commands
vim, vi, nano, emacs, ssh, telnet, opencode, less, more, htop, top, man, psql, mysql, sqlite3, python, python3, node, irb