feat(mcp): add OAuth redirect URI configuration for MCP servers #9034
+95
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-implements the redirectUri option for MCP OAuth configuration, allowing users to specify a custom callback URL for OAuth flows. Key difference from original PR anomalyco#7379: the OAuth callback server is now started lazily in startAuth() only when authentication is actually needed, rather than preemptively in create() for all remote servers. This fixes the regression where non-OAuth MCP servers would fail to connect. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Ensures the debug command uses the configured redirectUri when testing OAuth flows, making it consistent with the main auth flow. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Jan 17, 2026
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-implements the
redirectUrioption for MCP OAuth configuration, allowing users to specify a custom callback URL for OAuth flows.redirectUriconfig option toMcpOAuthschemaMcpOAuthProviderto use custom redirect URI when providedMcpOAuthCallback.ensureRunning()to support custom port/pathparseRedirectUri()utility functionKey difference from original PR #7379: The OAuth callback server is now started lazily in
startAuth()only when authentication is actually needed, rather than preemptively increate()for all remote servers. This fixes the regression where non-OAuth MCP servers would fail to connect.Closes #7377
Test plan
parseRedirectUritests pass (3 tests)ensureRunningwith custom redirectUri test passes (1 test)Manual test results