Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions packages/opencode/src/acp/agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,12 @@ export namespace ACP {
return
}

case "session.deleted": {
const sessionId = event.properties.info.id
this.closeSession(sessionId)
return
}

case "message.part.updated": {
log.info("message part updated", { event: event.properties })
const props = event.properties
Expand Down Expand Up @@ -1410,6 +1416,34 @@ export namespace ACP {
{ throwOnError: true },
)
}

/**
* Dispose of all session resources including event streams and session map entries.
* This should be called when the agent is being destroyed to prevent memory leaks.
*/
async dispose() {
log.info("disposing agent", { sessionCount: this.sessionManager["sessions"].size })

// Abort global event stream
this.eventAbort.abort()

// Clear all sessions from the manager
this.sessionManager.clear()
}

/**
* Close a specific session and clean up its resources.
* This should be called when a session is explicitly closed/ended.
*/
closeSession(sessionId: string) {
log.info("closing session", { sessionId })

// Remove from session manager
this.sessionManager.delete(sessionId)

// Clean up permission queue if present
this.permissionQueues.delete(sessionId)
}
}

function toToolKind(toolName: string): ToolKind {
Expand Down
8 changes: 8 additions & 0 deletions packages/opencode/src/acp/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@ export class ACPSessionManager {
this.sdk = sdk
}

delete(sessionId: string): boolean {
return this.sessions.delete(sessionId)
}

clear(): void {
this.sessions.clear()
}

tryGet(sessionId: string): ACPSessionState | undefined {
return this.sessions.get(sessionId)
}
Expand Down
Loading