Investigate size increase

[anonrig]

We should investigate if the size increase is worth the performance gain, that is included in the latest release.

Received a feedback on Twitter

According to Bundlephobia

• 1.0.0 is 3.6 kb (minified)
• 1.1.0 is 748 kb (minified)

[Uzlopak]

Yeah this is because multibyte Charakters are pre calculated. I made a memory speed trade off. We could calculate at startup. This could slow down the startup time. I could provide a PR if you like.

[anonrig]

I think we should do a comparison in performance once again.

[baraeb92]

Would it be possible for the user to be given the option to opt out on some optimizations?

So user can perhaps decide for themselves on whether 15% faster on some ops is a worthy tradeoff with extra 700k on the app?

That way user who wants to enjoy other features in newer version can do so, without having to pay the 700k toll.

Now my team decided to use the v1.0.0 instead to workaround this problem.

[Uzlopak]

I have somewhere on disk the function with which i generated the array in first place.

[mcollina]

I think we should revert that change. 700KB is hardly worth the improvement :(.

Happy to also switch Fastify back to node:query-string.

[anonrig]

@Uzlopak Can you revert the changes?

[Fdawgs]

I think we should revert that change. 700KB is hardly worth the improvement :(.

Happy to also switch Fastify back to node:query-string.

I thought disk space usage wasn't a concern for Fastify?

See fastify/skeleton#42