Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert changes to reduce size #44

Merged
merged 2 commits into from
Feb 4, 2023
Merged

fix: revert changes to reduce size #44

merged 2 commits into from
Feb 4, 2023

Conversation

anonrig
Copy link
Owner

@anonrig anonrig commented Feb 4, 2023

Fixes #40

Before

npm notice === Tarball Contents ===
npm notice 1.1kB   LICENSE
npm notice 5.9kB   README.md
npm notice 374B    lib/index.d.ts
npm notice 414B    lib/index.js
npm notice 4.5kB   lib/internals/querystring.js
npm notice 761.6kB lib/internals/utf16.js
npm notice 3.3kB   lib/parse.js
npm notice 1.7kB   lib/stringify.js
npm notice 1.5kB   package.json

npm notice package size:  152.6 kB
npm notice unpacked size: 780.3 kB

After

npm notice === Tarball Contents ===
npm notice 1.1kB LICENSE
npm notice 5.9kB README.md
npm notice 374B  lib/index.d.ts
npm notice 414B  lib/index.js
npm notice 2.6kB lib/internals/querystring.js
npm notice 3.3kB lib/parse.js
npm notice 1.7kB lib/stringify.js
npm notice 1.5kB package.json

npm notice package size:  5.3 kB
npm notice unpacked size: 16.9 kB

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #44 (a4fc792) into main (4df5590) will increase coverage by 0.60%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main       #44      +/-   ##
===========================================
+ Coverage   99.39%   100.00%   +0.60%     
===========================================
  Files           5         4       -1     
  Lines         333       311      -22     
  Branches       74        74              
===========================================
- Hits          331       311      -20     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
lib/internals/querystring.js 100.00% <100.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anonrig anonrig force-pushed the refactor-revert-size branch from 10280c5 to a4fc792 Compare February 4, 2023 20:15
@anonrig anonrig requested a review from mcollina February 4, 2023 20:15
@anonrig anonrig merged commit bd57316 into main Feb 4, 2023
@anonrig anonrig deleted the refactor-revert-size branch February 4, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate size increase
2 participants