-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating FORCE option #296
Creating FORCE option #296
Conversation
I can't test this for a few more weeks and not sure I understand value adding this force option as the idea is to not do anything if the there are no changes. It defeats the purpose of bumping versions only when changes are found. Maybe explain a bit more of some scenarios where this option is usefull. |
@sbe-arg yes sure. The scenario we are facing is, we have a release tag (where we have found an issue). So we want to create another release branch where we will fix the issue.
That's the way I thought can resolve our scenario. Again thanks for this solution :) |
What if we rename the force to something like. Update without commit changes. force_without_changes or alike. I'm still not sure about how this will impact existing workflows |
@sbe-arg code updated |
Hey all, |
The problem is I can merge it but I cannot test it. If I merge and there is trouble ill revert unless you keep and eye on this for a few days post merge. |
@sbe-arg the build had failed, but I am not sure what is causing that issue. https://github.com/anothrNick/github-tag-action/actions/runs/8291496983/job/22691303650#step:4:336 Seems to be a permission issue. For sure I can follow up on this change after it is published. I have a couple of repositories where I can test it |
We might need @anothrNick to add bot permissions bot the repo settings level |
I think this is related to the checkout v3. |
What do you need here? |
@anothrNick in theory this should fix the permission error to release this repo #307 |
@jcvegan forgot to edit the dockerfile or the entrypoint to trigger a new release. |
Hi @sbe-arg , I modified the entrypoint but not the dockerfile. Do you want me to create the PR for this change? is it only upgrading the node version? |
Yes just a dockerfile or entrypoin edit will trigger a new release is either or |
I have no idea why we suddenly have this problem
@anothrNick any ideas? we do have https://github.com/anothrNick/github-tag-action/blob/master/.github/workflows/main.yml#L19 write access |
Summary of changes
Adding a FORCE option to skip the condition if the release commit is the same commit from the tag.
This will allow users to create hotfix from a last release branch.
Added the FORCE option and add also the condition to skip the validation on commit.
Breaking Changes
Do any of the included changes break current behaviour or configuration?
(YES / NO)
How changes have been tested
List any unknowns