Fix Backwards Incompatible Config Additions #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was untested following a change
This was a copy/paste error
As the application mounts with the default config before the tests run, the default routes were already set
A backwards incompatible change was made, meaning if the config value wasn't set the ping and health routes would default to /
|
The fix for #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backwards incompatible change was spotted which defaulted the
/ping&/healthroutes for existing uses of the package using existing config to both listen on/.This adds a fallback so if the config doesn't exist it defaults to
/ping&/health.Alongside this, I've added a test for the
/pingcustomization and tweaked the/healthcustomisation test as this still had the default/healthroute due to how orchestra bootstraps Laravel.