Stop PHPUnit 10 being installed till we can fix deprecation errors in v9 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbibby
commented
Feb 16, 2023
|
I reckon we drop support for 5.6, maybe some 7.x versions and do a major version release. Can take the opportunity to see if there are any other breaking changes we want |
|
Reading this article yesterday I don't think the major version is needed https://sebastiandedeyne.com/composer-semver-and-underlying-dependency-changes/ But if there's any other changes we want to make (something round #63 possibly) it could be a good time to do a few things at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phpunit.de/announcements/phpunit-10.html
There's a bigger piece of work around supporting PHPUnit 10 so for now I think it's fine for us to stay on v9.
We should probably look at what PHP versions we want to support moving forwards and set up our testing dependency versions based on that.