instance script execution resource and ecloud credentials data source added #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4c6565
requested changes
Aug 1, 2024
|
|
||
| credentials, err := service.GetInstanceCredentials(d.Get("instance_id").(string), params) | ||
| if err != nil { | ||
| return diag.Errorf("Error retrieving active instances: %s", err) |
There was a problem hiding this comment.
active instances in error should be instance credentials
| } | ||
|
|
||
| if len(credentials) < 1 { | ||
| return diag.Errorf("No instances found with provided arguments") |
There was a problem hiding this comment.
instances in error should be credentials
| } | ||
|
|
||
| if len(credentials) > 1 { | ||
| return diag.Errorf("More than 1 instance found with provided arguments") |
There was a problem hiding this comment.
instance in error should be credential
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code and testing to allow the users to execute scripts on ecloud instances in terraform and retrieve instance credentials.