Merge pull request #373 from bcoca/patch-1

More complete missing lib msg adds 'exact' python used by module and hostname to avoid confusion ISSUE TYPE Bugfix Pull Request COMPONENT NAME firewalld Reviewed-by: Hideki Saito <saito@fgrep.org>
ansible-collections · Sep 16, 2022 · 0224e4d · 0224e4d
2 parents 5e0a659 + cc20dea
commit 0224e4d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelogs/fragments/373_firewall_fix_missing_library_message.yml b/changelogs/fragments/373_firewall_fix_missing_library_message.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - firewall - Fixed to output a more complete missing library message.
diff --git a/plugins/module_utils/firewalld.py b/plugins/module_utils/firewalld.py
@@ -5,6 +5,7 @@
 
 from __future__ import absolute_import, division, print_function
 from ansible_collections.ansible.posix.plugins.module_utils.version import LooseVersion
+from ansible.module_utils.basic import missing_required_lib
 
 __metaclass__ = type
 
@@ -314,6 +315,5 @@ def sanity_check(module):
 
         if import_failure:
             module.fail_json(
-                msg='Python Module not found: firewalld and its python module are required for this module, \
-                        version 0.2.11 or newer required (0.3.9 or newer for offline operations)'
+                msg=missing_required_lib('firewall') + '. Version 0.2.11 or newer required (0.3.9 or newer for offline operations)'
             )