Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to obtain Azure Kubernetes Service Credentials #1484

Conversation

Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented Mar 6, 2024

SUMMARY

Support to obtain Azure Kubernetes Service Credentials, try to fixes #1472

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_akscredentials_info.py

ADDITIONAL INFORMATION

@@ -33,6 +33,42 @@
outbound_type: loadBalancer
register: output

- name: Get managecluter admin credentials
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw here in many other place I guess you misspelled cluster as cluter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@em- Thanks for your review! Already modify!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority labels Mar 11, 2024
@xuzhang3 xuzhang3 merged commit 8bae823 into ansible-collections:dev Mar 22, 2024
@Fred-sun Fred-sun deleted the support-get-cluster-credentials-module branch March 25, 2024 02:45
Justwmz pushed a commit to Justwmz/azure that referenced this pull request Nov 4, 2024
…ctions#1484)

* Support to obtain Azure Kubernetes Service Credentials

* small change for test

* Modify test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
3 participants