Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azure_rm_cdnprofile to include the Standard and Premium Frontdoor options #1588

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Update azure_rm_cdnprofile to include the Standard and Premium Frontdoor options #1588

merged 7 commits into from
Jul 1, 2024

Conversation

jartoo
Copy link
Contributor

@jartoo jartoo commented Jun 6, 2024

SUMMARY

Adds the ability to use the existing azure_rm_cdnprofile module to create both a Standard_AzureFrontDoor and Premium_AzureFrontDoor.

Begins to work on #1041 which will require additional pull requests and new modules. This does not complete this issue, however. This also bumps the azure-mgmt-cdn version from 11.0.0 to 13.1.0, which is the latest and will be needed for upcoming pull requests to finish the Front Door (Standard and Premium) functionality.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Module: azure_rm_cdnprofile
Change: allows additional SKU options.

ADDITIONAL INFORMATION

@jartoo
Copy link
Contributor Author

jartoo commented Jun 6, 2024 •
edited
Loading

Additional modules being submitted in the future related to this one:

Others I am considering:

  • afd secrets?
  • managed rulesets?

@jartoo
Copy link
Contributor Author

jartoo commented Jun 6, 2024

Was not sure if you wanted all of the commits for each module done separately or not...assumed separate, though there are some cross dependencies with the tests, so they should be progressively accepted and then tested..tried getting feedback via email, but no engagement. Hope this is an acceptable approach. Thanks!

Fred-sun
Fred-sun reviewed Jun 7, 2024
View reviewed changes
plugins/modules/azure_rm_cdnprofile.py Outdated
@@ -129,7 +131,7 @@ def __init__(self):
),
sku=dict(
type='str',
choices=['standard_verizon', 'premium_verizon', 'custom_verizon', 'standard_akamai', 'standard_chinacdn', 'standard_microsoft']
choices=['standard_verizon', 'premium_verizon', 'custom_verizon', 'standard_akamai', 'standard_chinacdn', 'standard_microsoft', 'standard_azurefrontdoor', 'premium_azurefrontdoor']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (196 > 160 characters)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the feedback! Changed. Curious if I missed where these type of requirements/coding standards are located? Happy to conform!

@Fred-sun
Copy link
Collaborator

Fred-sun commented Jun 7, 2024

@jartoo small change request! Thank you very much!

@Fred-sun Fred-sun added question Further information is requested medium_priority Medium priority work in In trying to solve, or in working with contributors labels Jun 7, 2024
@jartoo jartoo mentioned this pull request Jun 10, 2024
Open
Fred-sun
Fred-sun reviewed Jun 10, 2024
View reviewed changes
plugins/modules/azure_rm_cdnprofile.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_cdnprofile.py Outdated Show resolved Hide resolved
@Fred-sun
Copy link
Collaborator

@jartoo small change request! Thank you!

@Fred-sun
Copy link
Collaborator

@jartoo Please!

@Fred-sun Fred-sun mentioned this pull request Jun 12, 2024
Merged
@jartoo jartoo mentioned this pull request Jun 14, 2024
Open
jartoo and others added 3 commits June 17, 2024 10:25
@jartoo
Merge branch 'ansible-collections:dev' into azure_rm_cdnprofile
d2f437a
@jartoo @Fred-sun
Update plugins/modules/azure_rm_cdnprofile.py
525d61c 
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@jartoo @Fred-sun
Update plugins/modules/azure_rm_cdnprofile.py
ed5b9c6 
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@jartoo
Copy link
Contributor Author

jartoo commented Jun 17, 2024

Thanks for all your help! I learned very much with these pull requests.

@jartoo
Copy link
Contributor Author

jartoo commented Jun 17, 2024

I updated the cdn library to be 13.1.1 due to this issue, which affects the ability to manage Azure Front Doors (standard and premium)

Azure/azure-sdk-for-python#35801

Otherwise you cannot clear the cache_configuration in Route() and Rule().

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 18, 2024
@Fred-sun Fred-sun added high_priority High priority and removed medium_priority Medium priority labels Jun 26, 2024
This was referenced Jun 28, 2024
Open
Open
@xuzhang3 xuzhang3 merged commit 8fd6350 into ansible-collections:dev Jul 1, 2024
Justwmz pushed a commit to Justwmz/azure that referenced this pull request Nov 4, 2024
@jartoo @Fred-sun @Justwmz
Update azure_rm_cdnprofile to include the Standard and Premium Frontd…
271507f 
…oor options (ansible-collections#1588)

* Update cdnprofile to include the Standard and Premium Frontdoor options

* Updated per Fred's request to split lengthy line of code.

* Update plugins/modules/azure_rm_cdnprofile.py

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* Update plugins/modules/azure_rm_cdnprofile.py

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* Must use azure.mgmt.cdn==13.1.1 to resolve cache_configuration set to NULL issue

---------

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fred-sun Fred-sun Fred-sun left review comments

@xuzhang3 xuzhang3 xuzhang3 approved these changes

Assignees

@xuzhang3 xuzhang3

Labels
high_priority High priority question Further information is requested ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jartoo @Fred-sun @xuzhang3