Add Managed Identity support to Redis Cache #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p3ck
added
ready_for_review
Fred-sun
reviewed
Aug 5, 2024
| - If the list of identities has to be appended to current identities (true) or if it has to replace current identities (false) | ||
| required: false | ||
| type: bool | ||
| default: False |
There was a problem hiding this comment.
@p3ck doc-default-does-not-match-spec: Argument 'append' in argument_spec found in identity -> user_assigned_identities defines default as (True) but documentation defines default as (False)
Fred-sun
reviewed
Aug 15, 2024
xuzhang3
approved these changes
Aug 16, 2024
Justwmz
pushed a commit
to Justwmz/azure
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds Managed Identity support to the rediscache module.
ISSUE TYPE
COMPONENT NAME
plugins/modules/azure_rm_rediscache.py
plugins/modules/azure_rm_rediscache_info.py
requirements.txt
tests/integration/targets/azure_rm_rediscache/tasks/main.yml
ADDITIONAL INFORMATION
Additional bug fixes to the test cases. Removing invalid or deprecated options.