Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_virtualmachineextension - Refs #1661 enable automatic update for vm extensions #1662

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

Klaas-
Copy link
Contributor

@Klaas- Klaas- commented Aug 5, 2024

SUMMARY

This partly fixes #1661

Add enable_automatic_upgrade as parameter

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_virtualmachineextension

@Fred-sun
Copy link
Collaborator

Fred-sun commented Aug 7, 2024

@Klaas- No problem, if you can add “'**

enable_automatic_upgrade': d.get('enable_automatic_upgrade', None)

**” to azure_rm_virtualmachineextension_info.py's format_response function. It will be better. Thank you!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority new_feature New feature requirments labels Aug 7, 2024
@Klaas-
Copy link
Contributor Author

Klaas- commented Aug 7, 2024

@Klaas- No problem, if you can add “'**

enable_automatic_upgrade': d.get('enable_automatic_upgrade', None)

**” to azure_rm_virtualmachineextension_info.py's format_response function. It will be better. Thank you!

Was planning on doing a 2nd PR for that, didn't get to it yet :)

@Fred-sun
Copy link
Collaborator

Fred-sun commented Aug 8, 2024

@Klaas- No problem, if you can add “'**

enable_automatic_upgrade': d.get('enable_automatic_upgrade', None)

**” to azure_rm_virtualmachineextension_info.py's format_response function. It will be better. Thank you!

Was planning on doing a 2nd PR for that, didn't get to it yet :)

Yes, because you are operating on the same property, you can put it in the same PR. Thank you!

@Klaas-
Copy link
Contributor Author

Klaas- commented Aug 8, 2024

@Klaas- No problem, if you can add “'**

enable_automatic_upgrade': d.get('enable_automatic_upgrade', None)

**” to azure_rm_virtualmachineextension_info.py's format_response function. It will be better. Thank you!

Was planning on doing a 2nd PR for that, didn't get to it yet :)

Yes, because you are operating on the same property, you can put it in the same PR. Thank you!

done, I am unsure however if it's handled correctly, the spec is not really clear to me

https://learn.microsoft.com/en-us/rest/api/compute/virtual-machine-extensions/get?view=rest-compute-2024-03-02&tabs=HTTP#virtualmachineextension

it says it's a boolean and always returned, but should have three states, True, False and "Not supported" or something like that, because automated updates are not supported with every extension afaik

@xuzhang3 xuzhang3 changed the title Refs #1661 enable automatic update for vm extensions azure_rm_virtualmachineextension - Refs #1661 enable automatic update for vm extensions Aug 15, 2024
@xuzhang3 xuzhang3 merged commit 8a58e88 into ansible-collections:dev Aug 15, 2024
Justwmz pushed a commit to Justwmz/azure that referenced this pull request Nov 4, 2024
…able automatic update for vm extensions (ansible-collections#1662)

* Refs ansible-collections#1661 enable automatic update for vm extensions

* Add enable_automatic_upgrade in virtual machine extension info module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_virtualmachineextension/azure_rm_virtualmachineextension_info support auto upgrade
3 participants