Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACA-1842: VM Image SKUs support in Ansible collection for Azure module creation #1719

Merged
merged 1 commit into from
Sep 27, 2024
Merged

ACA-1842: VM Image SKUs support in Ansible collection for Azure module creation #1719

merged 1 commit into from
Sep 27, 2024

Conversation

Yaish25491
Copy link
Contributor

SUMMARY

Creating azure_rm_imagesku_info module to get all of the available SKU options for VM image.
Creating azure_test_image_skus to test the creation of a VM with an image from the SKU list of options
Updating the test list in the inventory file with azure_test_imageskus test.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_imagesku_info.py
azure_test_image_skus.yml
azure_rm_virtualmachine/inventory.yml

@Fred-sun
Copy link
Collaborator

@Yaish25491 Please fix the below error! Thanks!
ERROR: Found 8 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/azure_rm_imagesku_info.py:30:161: E501: line too long (177 > 160 characters)
ERROR: plugins/modules/azure_rm_imagesku_info.py:34:161: E501: line too long (199 > 160 characters)
ERROR: plugins/modules/azure_rm_imagesku_info.py:77:161: E501: line too long (192 > 160 characters)
ERROR: plugins/modules/azure_rm_imagesku_info.py:168:48: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_imagesku_info.py:169:48: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_imagesku_info.py:177:73: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_imagesku_info.py:178:73: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_imagesku_info.py:184:1: W293: blank line contains whitespace

@Fred-sun Fred-sun added question Further information is requested medium_priority Medium priority work in In trying to solve, or in working with contributors labels Sep 18, 2024
@Yaish25491 Yaish25491 force-pushed the azure_rm_imagesku_info branch from 426d1bd to b534ae9 Compare September 19, 2024 08:34
@Yaish25491
Copy link
Contributor Author

Hi Fred-Sun,
All errors corrected and pushed again for review

@Fred-sun
Copy link
Collaborator

@Yaish25491

ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.properties.automaticOSUpgradeProperties: extra keys not allowed @ data['argument_spec']['properties']['automaticOSUpgradeProperties']. Got {'type': 'bool', 'default': 'false'}
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: nonexistent-parameter-documented: Argument 'publisher' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'id' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'properties' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'publisher_name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'tags' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'id' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'name' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'properties' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'publisher_name' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'tags' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:30:99: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_imagesku_info.py:35:133: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_imagesku_info.py:200:1: E302: expected 2 blank lines, found 1

@Yaish25491 Yaish25491 force-pushed the azure_rm_imagesku_info branch from b534ae9 to 4a8ca03 Compare September 19, 2024 13:13
@Yaish25491
Copy link
Contributor Author

issues fixed and merged

@Yaish25491
ACA-1842: Image SKUs support in Ansible collection -
2addaf6 
Creaing azure_rm_imagesku_info module to get oll of the availble SKU options for VM image.
Creating azure_test_image_skus to test the creation of a vm with an image from the SKU list of options
Updating the test list in the inventory file with azure_test_imageskus test.

Signed-off-by: hyaish <hyaish@redhat.com>
@Yaish25491 Yaish25491 force-pushed the azure_rm_imagesku_info branch from 4a8ca03 to 2addaf6 Compare September 24, 2024 07:19
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged new_module_pr Add new modules and removed question Further information is requested work in In trying to solve, or in working with contributors labels Sep 25, 2024
@xuzhang3 xuzhang3 merged commit 25b0a96 into ansible-collections:dev Sep 27, 2024
Justwmz pushed a commit to Justwmz/azure that referenced this pull request Nov 4, 2024
@Yaish25491 @Justwmz
ACA-1842: Image SKUs support in Ansible collection - (ansible-collect…
d95fdf0 
…ions#1719)

Creaing azure_rm_imagesku_info module to get oll of the availble SKU options for VM image.
Creating azure_test_image_skus to test the creation of a vm with an image from the SKU list of options
Updating the test list in the inventory file with azure_test_imageskus test.

Signed-off-by: hyaish <hyaish@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fred-sun Fred-sun Fred-sun left review comments

@xuzhang3 xuzhang3 xuzhang3 approved these changes

Assignees

@xuzhang3 xuzhang3

Labels
medium_priority Medium priority new_module_pr Add new modules ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yaish25491 @Fred-sun @xuzhang3