Fixed bugs caused by indent #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p3ck
previously approved these changes
Sep 26, 2024
|
Although I don't think this will fix #1726 since it's not a None object that is being acted on. I am unable to reproduce their problem so far. |
|
@p3ck Yeah, I never had that problem again. However, the return value is required to be a dictionary, which is convenient for later calls to update_identity. I am still dealing with this problem, thank you! |
Fred-sun
added
work in
Fred-sun
changed the title
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
Sep 29, 2024
Justwmz
pushed a commit
to Justwmz/azure
that referenced
this pull request
Nov 4, 2024
* The default identity return value is dict * Fix indent legacy bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The default identity return value is dict， try to fixes #1726
ISSUE TYPE
COMPONENT NAME
azure_rm_aks.py
ADDITIONAL INFORMATION