Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Major] Prepare release 5.0.0 #220

Merged
merged 5 commits into from
Dec 1, 2023
Merged

[Major] Prepare release 5.0.0 #220

merged 5 commits into from
Dec 1, 2023

Conversation

rohitthakur2590
Copy link
Contributor

SUMMARY
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@rohitthakur2590
[Major] Prepare release 5.0.0
3f6a46c 
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f04d8f0e3b24459f8a7a7f11bd46bc10

❌ ansible-galaxy-importer RETRY_LIMIT in 3m 29s
✔️ build-ansible-collection SUCCESS in 10m 51s
✔️ ansible-tox-linters SUCCESS in 12m 59s

@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Merging #220 (f7bcecf) into main (0101621) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files          24       24           
  Lines        1512     1512           
=======================================
  Hits         1126     1126           
  Misses        386      386

ashwini-mhatre
ashwini-mhatre reviewed Dec 1, 2023
View reviewed changes
Copy link

@ashwini-mhatre ashwini-mhatre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add .ansible-lint config file

@rohitthakur2590
add ansible-lint file
9409abd 
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
NilashishC
NilashishC reviewed Dec 1, 2023
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@rohitthakur2590 @NilashishC
Update CHANGELOG.rst
64117d1 
Co-authored-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2eb8036303c7431fa1cb5043f52422b9

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 10m 12s
✔️ ansible-tox-linters SUCCESS in 12m 22s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/42c8f975f4e04e2cae7426323e82b050

✔️ ansible-galaxy-importer SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 10m 00s
✔️ ansible-tox-linters SUCCESS in 12m 22s

@rohitthakur2590 rohitthakur2590 merged commit 81fd56e into ansible-collections:main Dec 1, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwini-mhatre ashwini-mhatre ashwini-mhatre approved these changes

@NilashishC NilashishC NilashishC approved these changes

@KB-perByte KB-perByte Awaiting requested review from KB-perByte

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitthakur2590 @ashwini-mhatre @NilashishC