Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint and Python 2.6 sanity ignore updates #255

Closed

Conversation

alisonlhart
Copy link

SUMMARY

This resolves Python 2.6 and Pylint errors showing in the Automation Hub import log for cisco.iosxr v3.2.0.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-test sanity ignore file (ignore-2.12.txt)

ADDITIONAL INFORMATION

This is not a current requirement, but removing all ansible-test sanity errors is encouraged by the community.
See this community-topics issue for reference: ansible-community/community-topics#96

Running sanity test "compile" on Python 2.6 
ERROR: Found 2 compile issue(s) on python 2.6 which need to be resolved: 
ERROR: plugins/module_utils/network/iosxr/config/ntp_global/ntp_global.py:172:36: SyntaxError: i["name"]: i for i in tmp["access_group"]["vrfs"] 
ERROR: plugins/module_utils/network/iosxr/config/snmp_server/snmp_server.py:355:54: SyntaxError: x["context"] = {y: {"name": y} for y in x["context"]} 

ERROR: Found 2 pylint issue(s) which need to be resolved: 
ERROR: tests/sanity/ignore-2.12.txt:31:1: ansible-test: Ignoring 'arguments-renamed' on 'plugins/cliconf/iosxr.py' is unnecessary 
ERROR: tests/sanity/ignore-2.12.txt:32:1: ansible-test: Ignoring 'arguments-renamed' on 'plugins/netconf/iosxr.py' is unnecessary 

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 4m 14s
ansible-changelog-fragment FAILURE in 18s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 38s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 28s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 22s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 8m 21s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 12s
ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 07s
✔️ ansible-test-units-iosxr-python36 SUCCESS in 6m 01s
✔️ ansible-test-units-iosxr-python37 SUCCESS in 6m 14s
✔️ ansible-test-units-iosxr-python38 SUCCESS in 6m 06s
✔️ ansible-test-units-iosxr-python39 SUCCESS in 4m 48s
✔️ ansible-tox-linters SUCCESS in 5m 24s

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 01s
✔️ build-ansible-collection SUCCESS in 3m 53s
✔️ ansible-changelog-fragment SUCCESS in 25s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 05s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 02s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 54s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 10m 57s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 33s
ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 27s
✔️ ansible-test-units-iosxr-python36 SUCCESS in 6m 37s
✔️ ansible-test-units-iosxr-python37 SUCCESS in 5m 46s
✔️ ansible-test-units-iosxr-python38 SUCCESS in 6m 29s
✔️ ansible-test-units-iosxr-python39 SUCCESS in 6m 55s
✔️ ansible-tox-linters SUCCESS in 5m 12s

@KB-perByte
Copy link
Contributor

recheck

@KB-perByte
Copy link
Contributor

Hey @alisonlhart would you please rebase the PR, I can get it merged right after that,

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 3m 47s
✔️ ansible-tox-linters SUCCESS in 4m 59s

@KB-perByte KB-perByte self-requested a review July 19, 2022 10:53
@alisonlhart
Copy link
Author

@KB-perByte Rebase is complete.

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 4m 06s
✔️ ansible-tox-linters SUCCESS in 5m 17s

@KB-perByte
Copy link
Contributor

Hey @alisonlhart I see some of the 2.12 sanity tests are failing considering the change that were made as of this PR.
I have a check PR based on main the tests are green without the changes #265 that is un-usual
would you please have a look
Regards

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 3m 47s
✔️ ansible-tox-linters SUCCESS in 5m 00s

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 58s
✔️ build-ansible-collection SUCCESS in 4m 02s
✔️ ansible-tox-linters SUCCESS in 5m 11s

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 3m 59s
✔️ ansible-tox-linters SUCCESS in 4m 55s

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/cisco.iosxr for 255,1c310656a67da8a74dfe75588f74b93414253ef7

@Ruchip16 Ruchip16 closed this Apr 10, 2024
@Ruchip16
Copy link
Contributor

closing this as we dont support python 2.6 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants