[PR #1064/d0c9f1a6 backport][stable-3] ec2_asg: Change purge_tags default value to False #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ec2_asg: Change purge_tags default value to False SUMMARY Changed default value of purge_tags to False. With the addition of purge_tags to ec2_asg module #960, the default value was kept to True similar to many other modules in this collection and also as specified in ansible dev guide. With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify purge_tags: false where required. This PR's change will prevent accidental breakage. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_asg Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> (cherry picked from commit d0c9f1a)
tremble
approved these changes
Apr 14, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/d0c9f1a6ee6198358a4ab2e59266e17ac10bfe25/pr-1064
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1064 as merged into main (d0c9f1a).
SUMMARY
Changed default value of
purge_tagstoFalse.With the addition of
purge_tagstoec2_asgmodule #960, the default value was kept toTruesimilar to many other modules in this collection and also as specified in ansible dev guide.With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify
purge_tags: falsewhere required.This PR's change will prevent accidental breakage.
ISSUE TYPE
COMPONENT NAME
ec2_asg