Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust booleans: use true/false #1420

Conversation

markuman
Copy link
Member

@markuman markuman commented Aug 24, 2022

Depends-On: #1423

SUMMARY

ansible-community/community-topics#116

ISSUE TYPE
  • Docs Pull Request

@github-actions
Copy link

github-actions bot commented Aug 24, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added community_review docs module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Aug 24, 2022
@markuman markuman added backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch labels Aug 24, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 5m 13s
✔️ build-ansible-collection SUCCESS in 5m 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 42s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 24s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 52s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 35s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 8m 10s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 20s
✔️ ansible-test-splitter SUCCESS in 2m 55s
✔️ integration-community.aws-1 SUCCESS in 33m 50s
✔️ integration-community.aws-2 SUCCESS in 7m 40s
✔️ integration-community.aws-3 SUCCESS in 23m 57s
✔️ integration-community.aws-4 SUCCESS in 47m 26s
✔️ integration-community.aws-5 SUCCESS in 22m 45s
integration-community.aws-6 FAILURE in 42m 19s
✔️ integration-community.aws-7 SUCCESS in 45m 22s
integration-community.aws-8 FAILURE in 8m 50s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman
Copy link
Member Author

the errors does not seem to be related to this PR

"msg": "Failed to enable AZ on load balancers: An error occurred (ValidationError) when calling the EnableAvailabilityZonesForLoadBalancer operation: You cannot enable Availability Zones for ELBs in a non default VPC",

and pip is failing

... core==1.20.40 because these package versions have conflicting dependencies.\nERROR: ResolutionImpossible

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 37s
✔️ build-ansible-collection SUCCESS in 5m 21s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 05s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 13s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 41s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 12s
✔️ ansible-test-splitter SUCCESS in 2m 33s
✔️ integration-community.aws-1 SUCCESS in 55m 39s
✔️ integration-community.aws-2 SUCCESS in 7m 55s
✔️ integration-community.aws-3 SUCCESS in 29m 07s
✔️ integration-community.aws-4 SUCCESS in 48m 16s
✔️ integration-community.aws-5 SUCCESS in 23m 52s
integration-community.aws-6 FAILURE in 42m 54s
✔️ integration-community.aws-7 SUCCESS in 44m 55s
integration-community.aws-8 FAILURE in 8m 34s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble
Copy link
Contributor

tremble commented Aug 25, 2022

recheck

@tremble
Copy link
Contributor

tremble commented Aug 25, 2022

#1423 should fix the botocore/boto3 install issues

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 4m 59s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 21s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 13s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 22s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 07s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 35s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 18s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-community.aws-1 SUCCESS in 54m 31s
✔️ integration-community.aws-2 SUCCESS in 8m 58s
✔️ integration-community.aws-3 SUCCESS in 23m 31s
✔️ integration-community.aws-4 SUCCESS in 43m 58s
✔️ integration-community.aws-5 SUCCESS in 27m 49s
integration-community.aws-6 FAILURE in 42m 16s
✔️ integration-community.aws-7 SUCCESS in 45m 01s
✔️ integration-community.aws-8 SUCCESS in 7m 39s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 39s
✔️ build-ansible-collection SUCCESS in 5m 02s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 29s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 25s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 24s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 35s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 04s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 05s
✔️ ansible-test-splitter SUCCESS in 2m 32s
integration-community.aws-1 FAILURE in 54m 47s
✔️ integration-community.aws-2 SUCCESS in 8m 25s
✔️ integration-community.aws-3 SUCCESS in 23m 37s
✔️ integration-community.aws-4 SUCCESS in 45m 34s
✔️ integration-community.aws-5 SUCCESS in 27m 33s
integration-community.aws-6 FAILURE in 45m 45s
✔️ integration-community.aws-7 SUCCESS in 50m 10s
✔️ integration-community.aws-8 SUCCESS in 6m 58s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 48s
✔️ build-ansible-collection SUCCESS in 4m 55s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 44s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 18s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 25s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 41s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 05s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 49s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 28m 45s
✔️ integration-community.aws-2 SUCCESS in 10m 02s
✔️ integration-community.aws-3 SUCCESS in 23m 52s
✔️ integration-community.aws-4 SUCCESS in 49m 05s
✔️ integration-community.aws-5 SUCCESS in 25m 45s
integration-community.aws-6 FAILURE in 41m 07s
✔️ integration-community.aws-7 SUCCESS in 44m 34s
✔️ integration-community.aws-8 SUCCESS in 9m 53s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman
Copy link
Member Author

rate limit error, that throws an exception in an exception

botocore.exceptions.ClientError: An error occurred (RequestLimitExceeded) when calling the DescribeVpnGateways operation (reached max retries: 4): Request limit exceeded.

During handling of the above exception, another exception occurred:

@markuman
Copy link
Member Author

recheck

@alinabuzachis
Copy link
Contributor

rate limit error, that throws an exception in an exception

botocore.exceptions.ClientError: An error occurred (RequestLimitExceeded) when calling the DescribeVpnGateways operation (reached max retries: 4): Request limit exceeded.

During handling of the above exception, another exception occurred:

Isn't this weird since jittered_backoff(retries=10)) has this config inside the ec2_vpc_vpn module and describe_vpc_gateways has aws_retry=True?

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 5m 08s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 15s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 29s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 22s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 49s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 22s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 11s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-community.aws-1 SUCCESS in 36m 15s
✔️ integration-community.aws-2 SUCCESS in 7m 56s
✔️ integration-community.aws-3 SUCCESS in 24m 00s
✔️ integration-community.aws-4 SUCCESS in 49m 10s
✔️ integration-community.aws-5 SUCCESS in 19m 34s
integration-community.aws-6 FAILURE in 41m 15s
✔️ integration-community.aws-7 SUCCESS in 43m 39s
✔️ integration-community.aws-8 SUCCESS in 8m 00s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman
Copy link
Member Author

rate limit error, that throws an exception in an exception

botocore.exceptions.ClientError: An error occurred (RequestLimitExceeded) when calling the DescribeVpnGateways operation (reached max retries: 4): Request limit exceeded.

During handling of the above exception, another exception occurred:

Isn't this weird since jittered_backoff(retries=10)) has this config inside the ec2_vpc_vpn module and describe_vpc_gateways has aws_retry=True?

yes, and it is constantly failing...

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 5m 05s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 34s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 16s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 47s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 23s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 24s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 12s
✔️ ansible-test-splitter SUCCESS in 2m 34s
integration-community.aws-1 FAILURE in 55m 01s
✔️ integration-community.aws-2 SUCCESS in 9m 14s
✔️ integration-community.aws-3 SUCCESS in 23m 48s
✔️ integration-community.aws-4 SUCCESS in 50m 55s
✔️ integration-community.aws-5 SUCCESS in 23m 23s
integration-community.aws-6 FAILURE in 40m 49s
✔️ integration-community.aws-7 SUCCESS in 46m 15s
✔️ integration-community.aws-8 SUCCESS in 8m 54s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 5m 19s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 07s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 07s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 21s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 16s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 15s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 46s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 52m 26s
✔️ integration-community.aws-2 SUCCESS in 7m 33s
✔️ integration-community.aws-3 SUCCESS in 24m 46s
✔️ integration-community.aws-4 SUCCESS in 58m 53s
✔️ integration-community.aws-5 SUCCESS in 24m 58s
✔️ integration-community.aws-6 SUCCESS in 49m 14s
✔️ integration-community.aws-7 SUCCESS in 44m 50s
✔️ integration-community.aws-8 SUCCESS in 7m 42s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman
Copy link
Member Author

party!!

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Aug 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 5m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 24s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 11s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 46s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 05s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 14s
✔️ ansible-test-splitter SUCCESS in 2m 37s
✔️ integration-community.aws-1 SUCCESS in 53m 28s
✔️ integration-community.aws-2 SUCCESS in 7m 55s
✔️ integration-community.aws-3 SUCCESS in 22m 22s
✔️ integration-community.aws-4 SUCCESS in 46m 32s
✔️ integration-community.aws-5 SUCCESS in 25m 08s
✔️ integration-community.aws-6 SUCCESS in 45m 05s
✔️ integration-community.aws-7 SUCCESS in 45m 01s
✔️ integration-community.aws-8 SUCCESS in 8m 04s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cb9716e into ansible-collections:main Aug 26, 2022
@patchback
Copy link

patchback bot commented Aug 26, 2022

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply cb9716e on top of patchback/backports/stable-3/cb9716e14d44357aaadd2be733bbaa0dd8a522bc/pr-1420

Backporting merged PR #1420 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-3/cb9716e14d44357aaadd2be733bbaa0dd8a522bc/pr-1420 upstream/stable-3
  4. Now, cherry-pick PR adjust booleans: use true/false #1420 contents into that branch:
    $ git cherry-pick -x cb9716e14d44357aaadd2be733bbaa0dd8a522bc
    If it'll yell at you with something like fatal: Commit cb9716e14d44357aaadd2be733bbaa0dd8a522bc is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x cb9716e14d44357aaadd2be733bbaa0dd8a522bc
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR adjust booleans: use true/false #1420 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-3/cb9716e14d44357aaadd2be733bbaa0dd8a522bc/pr-1420
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Aug 26, 2022

Backport to stable-4: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply cb9716e on top of patchback/backports/stable-4/cb9716e14d44357aaadd2be733bbaa0dd8a522bc/pr-1420

Backporting merged PR #1420 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-4/cb9716e14d44357aaadd2be733bbaa0dd8a522bc/pr-1420 upstream/stable-4
  4. Now, cherry-pick PR adjust booleans: use true/false #1420 contents into that branch:
    $ git cherry-pick -x cb9716e14d44357aaadd2be733bbaa0dd8a522bc
    If it'll yell at you with something like fatal: Commit cb9716e14d44357aaadd2be733bbaa0dd8a522bc is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x cb9716e14d44357aaadd2be733bbaa0dd8a522bc
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR adjust booleans: use true/false #1420 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-4/cb9716e14d44357aaadd2be733bbaa0dd8a522bc/pr-1420
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Sep 21, 2022
Adjust booleans from yes/no to true/false

SUMMARY

As per ansible-community/community-topics#116
See also ansible-collections/community.aws#1420
Closes: #1041
ISSUE TYPE


Docs Pull Request

COMPONENT NAME

several
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Bikouo Aubin <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@cb9716e
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@cb9716e
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@cb9716e
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@cb9716e
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@cb9716e
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@cb9716e
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@cb9716e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch community_review docs mergeit Merge the PR (SoftwareFactory) module module owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants