Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup opensearch when using advanced security options #1613

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Fixup opensearch when using advanced security options #1613

merged 6 commits into from
Dec 7, 2022

Conversation

gionn
Copy link
Contributor

@gionn gionn commented Dec 6, 2022 •
edited
Loading

Fix #1560

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @sebastien-rosset @tremble
click here for bot help

@ansibullbot ansibullbot added community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Dec 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 5m 16s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 43s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 8m 53s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 20s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 55s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 45s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 06s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 07s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 51s
❌ ansible-test-changelog FAILURE in 2m 16s
✔️ ansible-test-splitter SUCCESS in 2m 46s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@sebastien-rosset
Copy link
Contributor

AFAIK, the PR needs to have a changelog fragment. For example: https://github.com/ansible-collections/community.aws/pull/1603/files#diff-91b084c5e7be52b748a76fbb78c48b01265222a931ad815ce7e81a5f0ed17370

@markuman markuman added backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch labels Dec 6, 2022
@markuman
Copy link
Member

markuman commented Dec 6, 2022

@gionn yes, as @sebastien-rosset mentioned. Can you please add a changelog fragment?
And it would be very helpful if you can expand the integration test, that covers this bug.

@ansibullbot ansibullbot added integration tests/integration tests tests and removed small_patch Hopefully easy to review labels Dec 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 00s
✔️ build-ansible-collection SUCCESS in 5m 06s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 35s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 11m 05s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 06s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 29s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 47s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 55s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 44s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 50s
✔️ ansible-test-changelog SUCCESS in 2m 32s
✔️ ansible-test-splitter SUCCESS in 3m 07s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@gionn
Copy link
Contributor Author

gionn commented Dec 7, 2022

I should have addressed all the concerns, but I extended the integration tests blindly and I have no idea if they could work at first try, enabling master user may break the following tests.

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Dec 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 5m 56s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 31s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 11m 27s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 50s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 23s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 58s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 14s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 46s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 39s
✔️ ansible-test-changelog SUCCESS in 2m 32s
✔️ ansible-test-splitter SUCCESS in 3m 00s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6919bac into ansible-collections:main Dec 7, 2022
@patchback
Copy link

patchback bot commented Dec 7, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/6919bac1a2b0cd1ca4718105405a03c32d2d5fea/pr-1613

Backported as #1614

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 7, 2022
@gionn @patchback
Fixup opensearch when using advanced security options (#1613)
2a84dd9 
Fixup opensearch when using advanced security options

Fix #1560

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 6919bac)
@patchback patchback bot mentioned this pull request Dec 7, 2022
Merged
@patchback
Copy link

patchback bot commented Dec 7, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/6919bac1a2b0cd1ca4718105405a03c32d2d5fea/pr-1613

Backported as #1615

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 7, 2022
@gionn @patchback
Fixup opensearch when using advanced security options (#1613)
371e4f6 
Fixup opensearch when using advanced security options

Fix #1560

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 6919bac)
@patchback patchback bot mentioned this pull request Dec 7, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 7, 2022
@patchback
Fixup opensearch when using advanced security options (#1613) (#1615)
47c027a 
[PR #1613/6919bac1 backport][stable-5] Fixup opensearch when using advanced security options

This is a backport of PR #1613 as merged into main (6919bac).
Fix #1560

Reviewed-by: Markus Bergholz <git@osuv.de>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 7, 2022
@patchback
Fixup opensearch when using advanced security options (#1613) (#1614)
1f42ae9 
[PR #1613/6919bac1 backport][stable-4] Fixup opensearch when using advanced security options

This is a backport of PR #1613 as merged into main (6919bac).
Fix #1560

Reviewed-by: Markus Bergholz <git@osuv.de>
@gionn gionn deleted the opensearch-fixup branch December 7, 2022 11:53
@renovate renovate bot mentioned this pull request Dec 19, 2022
Merged
1 task
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@hakbailey
Document and validate backup_selection conditions suboptions (ansible…
cfeffe6 
…-collections#1633)

Document and validate backup_selection conditions suboptions

SUMMARY
Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes ansible-collections#1613
Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
backup_selection
module_utils.backup
ADDITIONAL INFORMATION
See ansible-collections#1613 for detailed description of related issue.

Reviewed-by: Jill R
Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create Elastic Search cluster using advanced security options
5 participants
@gionn @ansibullbot @sebastien-rosset @markuman @alinabuzachis