-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route53_wait module #1904
Add route53_wait module #1904
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 40s (non-voting) |
c98f4d9
to
44b896b
Compare
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 50s (non-voting) |
44b896b
to
ea112ef
Compare
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 13s (non-voting) |
ea112ef
to
3a596df
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 43s (non-voting) |
It looks like the user has no authorization to check progress for Route53 updates. I checked the route53 tests (in amazon.aws), none of them uses |
I created mattclay/aws-terminator#288 to update the permissions. |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 16s (non-voting) |
recheck |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 17s (non-voting) |
3cf0f39
to
5ce3466
Compare
Integration tests should now have a chance to complete, due to mattclay/aws-terminator#290. Unfortunately they currently do not run due to Python 3.9 being used with ansible-core devel/milestone. |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 49s (non-voting) |
recheck |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 51s (non-voting) |
I tested this module today with felixfontein/ansible-acme#62 to generate a larger set of certificates, and all worked well. Using this module instead of adding |
5ce3466
to
ef9ce9d
Compare
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 17s (non-voting) |
ef9ce9d
to
63f02a9
Compare
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 43s (non-voting) |
63f02a9
to
2ba4ba9
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 11s (non-voting) |
2ba4ba9
to
ff51918
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 06s (non-voting) |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 48s (non-voting) |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1927 🤖 @patchback |
Add route53_wait module SUMMARY Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false. Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now. ISSUE TYPE New Module Pull Request COMPONENT NAME route53 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis (cherry picked from commit a7cddf0)
@tremble @markuman @alinabuzachis thanks a lot for your help getting this merged! |
[PR #1904/a7cddf0e backport][stable-6] Add route53_wait module This is a backport of PR #1904 as merged into main (a7cddf0). SUMMARY Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false. Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now. ISSUE TYPE New Module Pull Request COMPONENT NAME route53 Reviewed-by: Markus Bergholz <git@osuv.de>
SUMMARY
Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with
wait=false
.Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now.ISSUE TYPE
COMPONENT NAME
route53