update elb_xxxx module adding ip_address_type option #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
ansibullbot
added
needs_revision
ansibullbot
added
community_review
has_issue
and removed
needs_revision
|
recheck |
jillr
reviewed
Apr 22, 2021
tests/integration/targets/elb_application_lb/tasks/test_alb_ip_address_type_options.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/elb_application_lb_info/tasks/setup.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
|
recheck |
abikouo
requested review from
jillr
and removed request for
Akasurde and
gravesm
jillr
approved these changes
Apr 27, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 15, 2021
…v2_ipaddress update elb_xxxx module adding ip_address_type option Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@dcbe694
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…v2_ipaddress update elb_xxxx module adding ip_address_type option Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@dcbe694
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 17, 2021
…v2_ipaddress update elb_xxxx module adding ip_address_type option Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@5d2e515
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
update elb_xxxx module adding ip_address_type option Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
update elb_xxxx module adding ip_address_type option Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
update elb_xxxx module adding ip_address_type option Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…tions#499) ec2_spot_instance cleanup imports SUMMARY Remove unused import, they're there for a future TODO While ansible-test ignores unused imports they're still a minor code smell and cleaning them up avoids potential issues in the future. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_spot_instance ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Sep 27, 2023
… retries enabled (#1768) elb_application_lb_info - ensure queries for additional ALB data have retries enabled SUMMARY As per #1767 the queries to pull extra info about ALBs are hitting rate limits when there's a lot of ALBs. Unfortunately the initial list operation has limited server-side filtering capabilities (and we don't have consistent client side filtering implemented at this time). Ensure that all of the extra queries have retries with jittered backoff enabled. Additionally, drops a redundant describe_load_balancers call to retrieve the ip_address_type information. (added by ansible-collections/community.aws#499) ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION I don't consider this a full fix for #1767 so I'm not using the "fixes". Reviewed-by: Alina Buzachis
patchback bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Sep 27, 2023
… retries enabled (#1768) elb_application_lb_info - ensure queries for additional ALB data have retries enabled SUMMARY As per #1767 the queries to pull extra info about ALBs are hitting rate limits when there's a lot of ALBs. Unfortunately the initial list operation has limited server-side filtering capabilities (and we don't have consistent client side filtering implemented at this time). Ensure that all of the extra queries have retries with jittered backoff enabled. Additionally, drops a redundant describe_load_balancers call to retrieve the ip_address_type information. (added by ansible-collections/community.aws#499) ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION I don't consider this a full fix for #1767 so I'm not using the "fixes". Reviewed-by: Alina Buzachis (cherry picked from commit d1c5f05)
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Sep 28, 2023
… retries enabled (#1768) (#1775) [PR #1768/d1c5f053 backport][stable-6] elb_application_lb_info - ensure queries for additional ALB data have retries enabled This is a backport of PR #1768 as merged into main (d1c5f05). SUMMARY As per #1767 the queries to pull extra info about ALBs are hitting rate limits when there's a lot of ALBs. Unfortunately the initial list operation has limited server-side filtering capabilities (and we don't have consistent client side filtering implemented at this time). Ensure that all of the extra queries have retries with jittered backoff enabled. Additionally, drops a redundant describe_load_balancers call to retrieve the ip_address_type information. (added by ansible-collections/community.aws#499) ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION I don't consider this a full fix for #1767 so I'm not using the "fixes". Reviewed-by: Mark Chappell
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 2, 2023
… retries enabled (ansible-collections#1768) elb_application_lb_info - ensure queries for additional ALB data have retries enabled SUMMARY As per ansible-collections#1767 the queries to pull extra info about ALBs are hitting rate limits when there's a lot of ALBs. Unfortunately the initial list operation has limited server-side filtering capabilities (and we don't have consistent client side filtering implemented at this time). Ensure that all of the extra queries have retries with jittered backoff enabled. Additionally, drops a redundant describe_load_balancers call to retrieve the ip_address_type information. (added by ansible-collections/community.aws#499) ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION I don't consider this a full fix for ansible-collections#1767 so I'm not using the "fixes". Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a new feature to add the new option ip_address_type for elb_xxx modules
Feature requested on issue #397
Depends on ansible-collections/amazon.aws#310
ISSUE TYPE
COMPONENT NAME
elb_application_lb
elb_application_lb_info
elb_network_lb
ADDITIONAL INFORMATION