Disable smoketests #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillr
changed the title
Smoketests are not needed in collections, and none exist in this collection anyway. ansible-collections/overview#45 (comment)
Stick with what works.
jillr
force-pushed
the
disable_smoketests
branch
from
6d444a8
to
9526609
Compare
|
@felixfontein would you be able to give this shippable.sh change a look over? |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Disable smoketests and use codecov pip package Smoketests are not needed in collections, and none exist in this collection anyway. ansible-collections/overview#45 (comment) * Not so fast on using codecov-python, not working at all in amazon.aws. Stick with what works.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Disable smoketests and use codecov pip package Smoketests are not needed in collections, and none exist in this collection anyway. ansible-collections/overview#45 (comment) * Not so fast on using codecov-python, not working at all in amazon.aws. Stick with what works.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ions#76) * Add link to ansible-maintained contributor guide etc * add 2.9 deprecation note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Smoketests are not needed in collections, and none exist in this
collection anyway.
ansible-collections/overview#45 (comment)
amazon.awswill be using the pip package, so keep this one consistent.We won't be using codecov-python, does not seem to be a drop-in replacement after all.
ISSUE TYPE
COMPONENT NAME
tests/utils/shippable/aws.sh
tests/utils/shippable/shippable.sh