Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass CSR to acme_certificate as csr_content #115

Conversation

felixfontein
Copy link
Contributor

SUMMARY

This allows to not write the CSR to disk, once openssl_csr (or another module) allows to generate it without disk access.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

acme_certificate

@felixfontein
Copy link
Contributor Author

ready_for_review

Copy link
Member

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM
The version_added is missing in the docs, is this still a thing?

@felixfontein
Copy link
Contributor Author

@resmo yes it is, I completely forgot (also in another PR) :) ansible/ansible#69291 should really get completed at some point...

BTW, I noticed I can improve openssl_get_csr_identifiers a bit by passing the CSR content in as stdin, instead of creating a temp file on disk.

@resmo
Copy link
Member

resmo commented Oct 9, 2020

@resmo yes it is, I completely forgot (also in another PR) :) ansible/ansible#69291 should really get completed at some point...

BTW, I noticed I can improve openssl_get_csr_identifiers a bit by passing the CSR content in as stdin, instead of creating a temp file on disk.

Got that, really nice.

@felixfontein
Copy link
Contributor Author

@resmo thanks a lot for reviewing this! I'll merge once CI passes (which will be in ~2 hours, since it's now clogged with the "nightly" builds...).

@felixfontein felixfontein merged commit 42dd19c into ansible-collections:main Oct 9, 2020
@felixfontein felixfontein deleted the acme_certificate-csr-content branch October 9, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants