Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude test folder from release #185

Closed
wants to merge 1 commit into from

Conversation

schurzi
Copy link

@schurzi schurzi commented Feb 5, 2021

SUMMARY

Don't include tests and pipeline definition in galaxy release, since these only increase package size and do not bring any benefit.

ISSUE TYPE
  • Bugfix Pull Request ?
  • Feature Pull Request ?
ADDITIONAL INFORMATION

currently following files are included in the release:

$ ls -la
total 196
drwxr-xr-x 7 root root   4096 Feb  5 18:50 .
drwxr-xr-x 3 root root   4096 Feb  5 17:00 ..
drwxr-xr-x 4 root root   4096 Feb  5 17:00 .azure-pipelines
-rw-r--r-- 1 root root  15691 Feb  5 17:00 CHANGELOG.rst
-rw-r--r-- 1 root root  35149 Feb  5 17:00 COPYING
-rw-r--r-- 1 root root 102410 Feb  5 17:00 FILES.json
-rw-r--r-- 1 root root    997 Feb  5 17:00 MANIFEST.json
-rw-r--r-- 1 root root   5459 Feb  5 17:00 README.md
drwxr-xr-x 3 root root   4096 Feb  5 18:51 changelogs
drwxr-xr-x 2 root root   4096 Feb  5 17:00 meta
drwxr-xr-x 7 root root   4096 Feb  5 17:00 plugins
drwxr-xr-x 6 root root   4096 Feb  5 17:00 tests

Should we also exclude the changelogs folder?

Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far the policy for community collections is to contain all material used to build them, and that includes test and CI config. (There are potential legal problems when we don't do that.)

Also, simply excluding all of tests/ is a Very Bad Idea, since this also excludes tests/sanity/, which makes it impossible to run sanity tests on the installed collection without getting new errors.

@schurzi
Copy link
Author

schurzi commented Feb 5, 2021

thank you for clarifying that. I will close this now, as there is nothing left to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants