Fix crash in x509_certificate #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajpantuso
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
LGTM as far as fixing the issue is concerned.
I checked the other backends and I didn't see any other references to self.path, but if it makes sense to have that attribute available it could just be initialized from the CertificateBackend base class instead of removing the references here.
|
I thought about that as well, but it will be kind of undefined for the |
|
@Ajpantuso @twouters thanks for reviewing and testing! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #240.
ISSUE TYPE
COMPONENT NAME
x509_certificate