Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: correct error message for docker sdk version #125

Conversation

daeseokyoun
Copy link
Contributor

SUMMARY

Annouced that 5.0.0 in Docker SDK for Python do not support Python 2.7 anymore.
When the system use Python 2.7, and run "pip install docker" command to
install Docker SDK for Python module. Then the 5.0.0 will be installed.

When occurred the error for mismatching version for Python 2.7, the user
could not feature it out why it failed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

common

ADDITIONAL INFORMATION

please check the PR on ansible.
ansible/ansible#74288

Annouced that 5.0.0 in Docker SDK for Python do not support Python 2.7 anymore.
When the system use Python 2.7, and run "pip install docker" command to
install Docker SDK for Python module. Then the 5.0.0 will be installed.

When occurred the error for mismatching version for Python 2.7, the user
could not feature it out why it failed.
@WojciechowskiPiotr WojciechowskiPiotr merged commit 18ccec6 into ansible-collections:main Apr 16, 2021
@WojciechowskiPiotr
Copy link
Collaborator

Thanks for the update. Merged!

@felixfontein
Copy link
Collaborator

This change - like every other code change - needs a changelog fragment. Please add it in a follow-up PR.

daeseokyoun added a commit to daeseokyoun/community.docker that referenced this pull request Apr 17, 2021
felixfontein added a commit that referenced this pull request Apr 17, 2021
* adds missing changelog fragment file

changelog fragment file for #125

* Update changelogs/fragments/125-correct-error-message-for-docker-sdk-version.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants