Minor fixes to nsenter connection plugin #249
Merged
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2021 12:01
- Ensure the nsoption_pid option is retrieved in _connect instead of __init__ to prevent a crasher due to initialization order - Replace the use of --all-namespaces with specific namespaces to support compatibility with Busybox nsenter (for example, Alpine)
felixfontein
reviewed
Dec 2, 2021
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment?
|
@jgoldschrafe I'm planning to do the bugfix release I announced last week by latest this weekend, so if you want to get this in, please try to work on it until then :) |
|
Updated, thank you! |
felixfontein
reviewed
Dec 8, 2021
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Dec 9, 2021
Backport to stable-1: 💚 backport PR created✅ Backport PR branch: Backported as #251 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Minor fixes to nsenter connection plugin - Ensure the nsoption_pid option is retrieved in _connect instead of __init__ to prevent a crasher due to initialization order - Replace the use of --all-namespaces with specific namespaces to support compatibility with Busybox nsenter (for example, Alpine) * minor tidy * Fix PEP8 violation * Changelog fragment * Update changelogs/fragments/249-nsenter-fixes.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Jeff Goldschrafe <jeff.goldschrafe@flatiron.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit d224752)
|
@jgoldschrafe thanks for fixing this! |
felixfontein
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Minor fixes to nsenter connection plugin - Ensure the nsoption_pid option is retrieved in _connect instead of __init__ to prevent a crasher due to initialization order - Replace the use of --all-namespaces with specific namespaces to support compatibility with Busybox nsenter (for example, Alpine) * minor tidy * Fix PEP8 violation * Changelog fragment * Update changelogs/fragments/249-nsenter-fixes.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Jeff Goldschrafe <jeff.goldschrafe@flatiron.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit d224752) Co-authored-by: Jeff Goldschrafe <jgoldschrafe@users.noreply.github.com>
This was referenced Dec 9, 2021
Merged
1 task
spantaleev
added a commit
to devture/docker-ansible
that referenced
this pull request
Apr 21, 2022
Related to: - https://docs.ansible.com/ansible/latest/collections/community/docker/nsenter_connection.html - ansible-collections/community.docker#249 The Docker community collection that's installed in Alpine 3.15 is old and doesn't contain the aforementioned nsenter plugin patch, so `--connection=community.docker.nsenter` doesn't work there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Two fixes to the nsenter connection plugin:
nsenter_pidoption is retrieved in_connectinstead of__init__to prevent a crasher due to bad initialization order--all-namespaceswith specific namespaces to support compatibility with Busybox nsenter (used on for example, Alpine containers)ISSUE TYPE
COMPONENT NAME
nsenter connection plugin
ADDITIONAL INFORMATION
N/A