-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make current_container_facts work with newer Docker versions and latest ansible-test container changes #510
Make current_container_facts work with newer Docker versions and latest ansible-test container changes #510
Conversation
7326aa3
to
f5ade36
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
CC @mattclay, looking at /proc/self/cpuset to figure out the current container breaks down on newer Docker daemons, and also no longer works with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the outdated comment and test with docker, look good. Podman worked flawlessly
@felixfontein Looking at $ docker run -it --rm --cgroupns host quay.io/bedrock/alpine:3.17.0 cat /proc/self/cpuset
/docker/a34f76a8f390f33188505c9be17734fcd41d6b1afc014bb36ad0b030a24ffe11
$ docker run -it --rm --cgroupns private quay.io/bedrock/alpine:3.17.0 cat /proc/self/cpuset
/ |
@kristianheljas @mattclay thanks for testing, reviewing, and commenting! |
…st ansible-test container changes (ansible-collections#510) * Add more debug output. * Add basic integration test. * Split into lines. * Fix docker detection, add podman detection. ci_complete * Improve regular expression. * Document that this module is trying its best, but might not be perfect. * Update comment. (cherry picked from commit c2d84ef)
Manual backport of bugfix part to stable-2 in #512. |
…ns and latest ansible-test container changes (#512) * Make current_container_facts work with newer Docker versions and latest ansible-test container changes (#510) * Add more debug output. * Add basic integration test. * Split into lines. * Fix docker detection, add podman detection. ci_complete * Improve regular expression. * Document that this module is trying its best, but might not be perfect. * Update comment. (cherry picked from commit c2d84ef) * Remove new feature (podman support).
…ns and latest ansible-test container changes (#512) * Make current_container_facts work with newer Docker versions and latest ansible-test container changes (#510) * Add more debug output. * Add basic integration test. * Split into lines. * Fix docker detection, add podman detection. ci_complete * Improve regular expression. * Document that this module is trying its best, but might not be perfect. * Update comment. (cherry picked from commit c2d84ef) * Remove new feature (podman support). (cherry picked from commit 3da9aa3)
SUMMARY
It does seem to no longer work, might be related to ansible/ansible#78550.
ISSUE TYPE
COMPONENT NAME
current_container_facts