-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolve homebrew and homebrew_cask package name validation issues (#1038
) Add basic regression tests Add changelog Rename _create_regex_group to better suit function Fix '-' use in Homebrew validation
- Loading branch information
1 parent
4842f67
commit 4c379bd
Showing
5 changed files
with
62 additions
and
14 deletions.
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
changelogs/fragments/1038-fix-homebrew-and-homebrew-cask-package-validation.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
bugfixes: | ||
- homebrew - fix package name validation for packages containing hypen ``-`` | ||
(https://github.com/ansible-collections/community.general/issues/1037). | ||
- homebrew_cask - fix package name validation for casks containing hypen ``-`` | ||
(https://github.com/ansible-collections/community.general/issues/1037). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) | ||
|
||
from __future__ import (absolute_import, division, print_function) | ||
|
||
__metaclass__ = type | ||
|
||
from ansible_collections.community.general.tests.unit.compat import unittest | ||
from ansible_collections.community.general.plugins.modules.packaging.os.homebrew import Homebrew | ||
|
||
|
||
class TestHomebrewModule(unittest.TestCase): | ||
|
||
def setUp(self): | ||
self.brew_app_names = [ | ||
'git-ssh', | ||
'awscli@1', | ||
'bash' | ||
] | ||
|
||
def test_valid_package_names(self): | ||
for name in self.brew_app_names: | ||
self.assertTrue(Homebrew.valid_package(name)) |
21 changes: 21 additions & 0 deletions
21
tests/unit/plugins/modules/packaging/os/test_homebrew_cask.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) | ||
|
||
from __future__ import (absolute_import, division, print_function) | ||
|
||
__metaclass__ = type | ||
|
||
from ansible_collections.community.general.tests.unit.compat import unittest | ||
from ansible_collections.community.general.plugins.modules.packaging.os.homebrew_cask import HomebrewCask | ||
|
||
|
||
class TestHomebrewCaskModule(unittest.TestCase): | ||
|
||
def setUp(self): | ||
self.brew_cask_names = [ | ||
'visual-studio-code', | ||
'firefox' | ||
] | ||
|
||
def test_valid_cask_names(self): | ||
for name in self.brew_cask_names: | ||
self.assertTrue(HomebrewCask.valid_cask(name)) |