Return correct values when running yarn in check mode

[imjoseangel]

SUMMARY

Fixes #152

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

yarn module

ADDITIONAL INFORMATION

When running check mode on yarn module, it returns an empty string by default when it expects two values for err and out. For instance:

out, err = yarn.install()

Currently the return is like:

return ''

and should be at least:

return(None, None)

From my point of view, this module needs to be have some checks for idempotency and dry-runs, but for now this will fix the issue. If you think it is interesting refactoring it, let me know and I can work on it.

After the change

changed: [localhost] => {
    "changed": true,
    "err": null,
    "invocation": {
        "module_args": {
            "executable": null,
            "global": true,
            "ignore_scripts": false,
            "name": "now",
            "path": null,
            "production": false,
            "registry": null,
            "state": "present",
            "version": null
        }
    },
    "out": null
}

[Akasurde]

@imjoseangel Thanks for the PR. Could you please add a change log entry and integration test for this change? Thanks.

[imjoseangel]

@Akasurde added simple tests for check mode when installing all packages. I think this module can be refactored with indempotency and BDD in mind in a different PR but I don't know if the effort worths it.

What do you think?

[ansibullbot]

cc @chrishoffman @verkaufer
click here for bot help

[felixfontein]

@imjoseangel thanks for fixing this!