zfs_delegate_admin: add diff,hold,release to list of permissions

[lotheac]

Moved from ansible/ansible#64562

SUMMARY

zfs_delegate_admin module has a whitelist of zfs permissions that it can manage. 'hold', 'release', and 'diff' are missing, so add them (in theory this list should also include all properties, but hold/release fix my immediate problem :)

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

zfs_delegate_admin module

[ansibullbot]

cc @bcoca @danowar2k @fishman @jasperla @jpdasma @mator @natefoo @scathatheworm @troy2914 @xen0l
click here for bot help

[Andersson007]

Hey, thanks for the PR!
Please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
Something like:

bugfixes:
- zfs_delegate_admin - add missed choices ... ... ... to the permissions parameter (https://github.com/ansible-collections/community.general/pull/278).

or maybe minor_changes instead of bugfixes, e.g. if these options were introduce recently.

[Andersson007]

LGTM

[Andersson007]

@lotheac thank you for the PR!

[Andersson007]

merged into master

[sriccio]

Thank you!

[felibb]

Maybe a dumb question, but how will this find its way back into ansible repository now? I asked here ansible/ansible#69945, but was told that is it "up to the author of the PR, or any other concerned user to submit backport PRs" to ansible repository.

[felixfontein]

@felibb someone has to create a backport of this PR for ansible/ansible's stable-2.9 branch. The general procedure is described here: https://docs.ansible.com/ansible/devel/community/development_process.html#backporting-merged-prs except that it isn't that simple anymore, since you cannot simply cherry-pick this commit (it's in the wrong repo etc.). You would have to manually re-create an equivalent commit.

[felibb]

@felixfontein I see. So if this module was moved out of ansible main repo into the current one, what is the general idea going forward? How could users obtain any new fixes and features provided by these modules in the current repo? Again, sorry if this is a dumb question, but both replies combined confused me further.

[lotheac]

On Tue, Jun 09 2020 12:52:51 +0000, Phil wrote: Maybe a dumb question, but how will this find its way back into ansible repository now? I asked here ansible/ansible#69945, but was told that is it "up to the author of the PR, or any other concerned user to submit backport PRs" to ansible repository.

AIUI - zfs_delegate_admin and lots of other modules were removed from ansible/ansible and moved here (community.general) - there is nothing to backport, since the modules no longer exist in the ansible repository. I don't know how the modules maintained here in community.general will make it to future ansible releases (2.10). I suppose someone could send a PR to backport this to 2.9, according to https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html it still accepts general bug fixes (and still contains the module in question). But I would just wait to see how 2.10 will do things.

…

-- Lauri Tirkkonen | lotheac @ IRCnet

[felixfontein]

@felibb @lotheac please see https://github.com/ansible-collections/overview/blob/master/status.rst (and the documents linked there) for details on how development of Ansible and collections continues, and how the modules will be included in future Ansible releases (short version: ansible/ansible is ansible-base, and the ansible Python package will be ansible-base + a set of collections, including this one).

[lotheac]

On Tue, Jun 09 2020 06:11:14 -0700, Felix Fontein wrote: @felibb @lotheac please see https://github.com/ansible-collections/overview/blob/master/status.rst for details on how development of Ansible and collections continues, and how the modules will be included in future Ansible releases (short version: ansible/ansible is ansible-base, and the ansible Python package will be ansible-base + a set of collections, including this one).

thanks, that clarifies things. @felibb since ansible/ansible#64562 was originally opened against ansible and the commit therein was still reachale, I didn't need to do much - just rebased it on top of stable-2.9: ansible/ansible#69962

…

-- Lauri Tirkkonen | lotheac @ IRCnet

[felibb]

@felixfontein thanks for the doc.

@lotheac thanks for backport PR!