Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #3378/06345839 backport][stable-3] opentelemetry callback: context propagation and error exception #3381

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Sep 16, 2021

This is a backport of PR #3378 as merged into main (0634583).

SUMMARY
  1. Add context propagation then it can be integrated with some other tools.
  2. Handle task failures as errors.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/callback/opentelemetry.py

COMPONENT NAME
ADDITIONAL INFORMATION

Reported errors:

image

Context propagation:

image

In order to test this particular plugin you could use jenkinsci/opentelemetry-plugin#166.

NOTE: There is an open discussion open-telemetry/opentelemetry-specification#740 for the traceparent standardisation.

* opentelemetry callback: context propagation and error exception

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 0634583)
@ansibullbot ansibullbot added backport callback callback plugin feature This issue/PR relates to a feature request new_contributor Help guide this first time contributor plugins plugin (any type) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 16, 2021
@felixfontein felixfontein merged commit 2c79d42 into stable-3 Sep 16, 2021
@felixfontein felixfontein deleted the patchback/backports/stable-3/06345839c6e333f9021d255af5e2707ecbba2c12/pr-3378 branch September 16, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback callback plugin feature This issue/PR relates to a feature request needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants