scaleway_compute: When removing node, wait for transition #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
bug
olof
force-pushed
the
scaleway_compute_state_transition_stopping
branch
from
bb1b171 to
276789a
Compare
|
The Edit: found #402, which describes this issue. |
|
recheck |
ansibullbot
removed
needs_triage
new_contributor
Andersson007
reviewed
Jun 9, 2020
To remove a scaleway compute node, one needs to stop it first. This is handled internally within the module by shutting down before removing. Shutting down the node transitions it to a "stopping" state, which is not the "stopped" state we expect. We thus need the transition to complete so that we can put it in the actual target state (absent, i.e. delete it). The mechanism for waiting for such transitions today is controlled by module parameters, with default to not being enabled at all, which includes the transition from ([running] -(stopping)-> [stopped]). Without this chage, in case of a running node, we would shut it down (transition it to "stopping"), not wait for it complete the transition, realize that it's not yet stopped and issue a second shut down command to the api. This would fail with a 400 Bad Request error, "already stopped". Reference: ansible/ansible#45740 Reported-by: zwindler
olof
force-pushed
the
scaleway_compute_state_transition_stopping
branch
from
276789a to
1bbca26
Compare
|
@sieben , as the module's author, could you please take a look? |
|
shipit |
|
@remyleone thanks for fast reply! |
|
@olof thanks for the contribution! |
|
merged #444 into master |
|
Super, thanks everybody involved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
To remove a scaleway compute node, one needs to stop it first. This is
handled internally within the module by shutting down before removing.
Shutting down the node transitions it to a "stopping" state, which is
not the "stopped" state we expect. We thus need the transition to
complete so that we can put it in the actual target state (absent, i.e.
delete it).
The mechanism for waiting for such transitions today is controlled by
module parameters, with default to not being enabled at all, which
includes the transition from ([running] -(stopping)-> [stopped]).
Without this chage, in case of a running node, we would shut it down
(transition it to "stopping"), not wait for it complete the transition,
realize that it's not yet stopped and issue a second shut down command
to the api. This would fail with a 400 Bad Request error, "already
stopped".
ISSUE TYPE
COMPONENT NAME
scaleway_compute
ADDITIONAL INFORMATION
This was originally reported as ansible/ansible#45740, and proposed in ansible/ansible#68392.
(Edit: initially wrong component name. Updated.)