rshm_repository: reduce execution time when changed == False

[giovannisciortino]

SUMMARY

This PR reduce of about 50% the execution time of this module when the module doesn't change the state of RHSM repositories.

Fixes #452

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

rhsm_repository

ADDITIONAL INFORMATION

This module execute the command subscription-manager two times:

1. Executing "subscription-manager repos --list" to identify enabled/disabled repositories before execute any change
2. Executing "subscription-manager repos " to enable/disable repositories and change the state of enabled/disabled repositories

The execution of subscription-manager command in some condition is slow (it can take about 40 seconds)
Before this PR, this module call subscription-manager always two times also when there aren't changes.
After this PR, this module skip the second execution of subscription-manager when there aren't changes.

Before PR

$ time ansible all -i /tmp/tmp -m rhsm_repository -a 'name=codeready-builder-for-rhel-8-x86_64-rpms'
...
    "changed": false,
...
    "results": [
        "Repository 'codeready-builder-for-rhel-8-x86_64-rpms' is enabled for this system."
    ]
}
real	1m31,856s
user	0m15,253s
sys	0m0,885s

After PR

$ time ansible all -i /tmp/tmp -m rhsm_repository -a 'name=codeready-builder-for-rhel-8-x86_64-rpms'
...
    "changed": false,
...
    "results": [
        "Repository 'codeready-builder-for-rhel-8-x86_64-rpms' is enabled for this system."
    ]
}
real	0m43,459s
user	0m7,632s
sys	0m0,498s

[ansibullbot]

cc @bcoca @danowar2k @fishman @jasperla @jpdasma @mator @mavit @scathatheworm @troy2914 @xen0l
click here for bot help

[pabelanger]

recheck

[pabelanger]

recheck

[Andersson007]

Please add a changelog fragment https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to

[giovannisciortino]

I added the "changelog fragment". Thanks for the review

[Andersson007]

@giovannisciortino thanks for the contribution!

[Andersson007]

merged #458 into master