xfconf module utils: providing a cmd_runner object #4776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
felixfontein
added
check-before-release
felixfontein
approved these changes
Jun 4, 2022
|
Please wait until #4777 is merged so I can add that improvement here as well. |
|
@russoz please add the improvement here as well, since that PR has been merged :) |
felixfontein
approved these changes
Jun 6, 2022
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #4789 🤖 @patchback |
|
@russoz thanks for this improvement! |
patchback bot
pushed a commit
that referenced
this pull request
Jun 6, 2022
* xfconf: changed implementation to use cmd_runner * added module_utils/xfconf.py * xfconf_info: using cmd_runner * added module_utils to BOTMETA.yml * added changelog fragment * use cmd_runner_fmt instead of deprecated form (cherry picked from commit 8ba3d94)
felixfontein
removed
the
check-before-release
felixfontein
pushed a commit
that referenced
this pull request
Jun 6, 2022
* xfconf: changed implementation to use cmd_runner * added module_utils/xfconf.py * xfconf_info: using cmd_runner * added module_utils to BOTMETA.yml * added changelog fragment * use cmd_runner_fmt instead of deprecated form (cherry picked from commit 8ba3d94) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
1 task
1 task
1 task
1 task
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Create a new
module_utils/xfconf.py.Changed
xfconfandxfconf_infoto use that runner instead of the features inCmdStateModuleHelperISSUE TYPE
COMPONENT NAME
plugins/module_utils/xfconf.py
plugins/modules/system/xfconf.py
plugins/modules/system/xfconf_info.py