Added conditional to only collect qmpstatus on qemu VMs

[Thulium-Drake]

SUMMARY

This fixes an issue with LXC containers after #4723 was implemented. I completely missed this when reviewing it and the unit tests didn't cover it :-)

I'm not too sure however on how to update the unit tests in order to fix this (yet, but it's late, unless I come up with an idea earlier then someone else, I'll adjust the tests as well :-) )

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

proxmox inventory

ADDITIONAL INFORMATION

Running the module without this task results in the errors below:

[WARNING]:  * Failed to parse /opt/ansible/projects/element-networks/inventory/04_nc_proxmox.yml with
ansible_collections.community.general.plugins.inventory.proxmox plugin: 'qmpstatus'
  File "/usr/lib/python3/dist-packages/ansible/inventory/manager.py", line 290, in parse_source
    plugin.parse(self._inventory, self._loader, source, cache=cache)
  File "/opt/ansible/projects/element-networks/collections/ansible_collections/community/general/plugins/inventory/proxmox.py", line 656, in parse
    self._populate()
  File "/opt/ansible/projects/element-networks/collections/ansible_collections/community/general/plugins/inventory/proxmox.py", line 597, in _populate
    name = self._handle_item(node['node'], ittype, item)
  File "/opt/ansible/projects/element-networks/collections/ansible_collections/community/general/plugins/inventory/proxmox.py", line 507, in _handle_item
    self._get_vm_status(properties, node, vmid, ittype, name)
  File "/opt/ansible/projects/element-networks/collections/ansible_collections/community/general/plugins/inventory/proxmox.py", line 446, in _get_vm_status
    properties[self._fact('qmpstatus')] = ret['qmpstatus']

[ansibullbot]

cc @Ajpantuso @ilijamt @joshainglis @karmab @tleguern
click here for bot help

[ilijamt]

@Thulium-Drake do you think maybe we can just use a default value if not set instead of a vm type check. As qmpstatus doesn't mean it's set even if you have QEMU machine, it will only be set when there are facts.

Yeah, weird that the tests missed it.

[ilijamt]

The tests missed the issue because we mock the _get_json.

community.general/tests/unit/plugins/inventory/test_proxmox.py

Line 570 in b556b14

inventory._get_json = mocker.MagicMock(side_effect=get_json)

This will require a bit more work to add tests for this.

[felixfontein]

Thanks for the fix! Could you please add a changelog fragment? Thanks.

[Thulium-Drake]

For some reason I run into some weird errors when trying the unit tests on my laptop, but I made some changes to them. It should now 'just' collect statuses from the mocked API instead of noop-ing :-)