[PR #6011/92544993 backport][stable-6] community.general.osx_defaults: Include stderr in error messages

[patchback]

This is a backport of PR #6011 as merged into main (9254499).

SUMMARY

Previously community.general.osx_defaults included the stdout in error messages when defaults returned a non-zero exit code. This was usually blank and not helpful. This PR changes it to include the stderr.

ISSUE TYPE

• Bugfix Pull Request
• Docs Pull Request

COMPONENT NAME

osx_defaults

ADDITIONAL INFORMATION

Example:

This task results in an error without become: true

- name: "Disable Automatic Quote Substitution"
  community.general.osx_defaults:
    state: present
    domain: NSGlobalDomain
    key: "NSAutomaticQuoteSubstitutionEnabled"
    type: bool
    value: false

Before: no helpful information is included in the error:

fatal: [host]: FAILED! => {"changed": false, "msg": "An error occurred while writing value to defaults: "}

After: stderr is included in the error

TASK [Disable Automatic Quote Substitution] ***************************************************************************************************
fatal: [host]: FAILED! => {"changed": false, "msg": "An error occurred while writing value to defaults: 2023-02-18 05:03:19.888 defaults[8711:1213879
2] Could not write domain Apple Global Domain; exiting\n"}

This does not change the case when the task is successful:

- name: "Disable Automatic Quote Substitution"
  community.general.osx_defaults:
    state: present
    domain: NSGlobalDomain
    key: "NSAutomaticQuoteSubstitutionEnabled"
    type: bool
    value: false
  become: true

TASK [Disable Automatic Quote Substitution] ***************************************************************************************************
ok: [host]

[ansibullbot]

cc @!UNKNOWN @Akasurde @danieljaouen @indrajitr @kyleabenson @martinm82 @notok
click here for bot help