Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate firewalld to ansible.posix #623

Merged

Conversation

maxamillion
Copy link
Contributor

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

migrate firewalld to ansible.posix

moved to ansible-collections/ansible.posix#68

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

firewalld

@ansibullbot ansibullbot added affects_2.10 community_review feature This issue/PR relates to a feature request integration tests/integration module module module_utils module_utils needs_triage plugins plugin (any type) system tests tests labels Jul 6, 2020
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta/runtime.yml Outdated Show resolved Hide resolved
@maxamillion
Copy link
Contributor Author

recheck

@felixfontein
Copy link
Collaborator

This still needs a changelog fragment.

@maxamillion when will ansible.posix be released with the firewalld module in it?

@maxamillion
Copy link
Contributor Author

@felixfontein +1 definitely need a changelog fragment, thank you! I can release the ansible.posix minor release whenever. It could even be the same day the PR is merged to pull the content into that collection if needed.

@felixfontein
Copy link
Collaborator

@maxamillion I'm not sure how we want to proceed with moving content after ansible_builtin_runtime.yml is frozen. I think we'll have to discuss this at the community meeting first (maybe even next week, since gundalow is away this week).

@ansibullbot ansibullbot added has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Jul 13, 2020
@maxamillion
Copy link
Contributor Author

@felixfontein fair point, worst case scenario I'll maintain both places for the overlap timeframe. I'd prefer not to but if necessary, that's always an option.

@maxamillion
Copy link
Contributor Author

For posterity: because the RC1 is delayed it was approved to do the migration now

Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion maxamillion force-pushed the firewalld-migration branch from 1c916be to cd273ef Compare July 15, 2020 21:29
@ansibullbot ansibullbot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 15, 2020
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI stale_ci CI is older than 7 days, rerun before merging and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI stale_ci CI is older than 7 days, rerun before merging labels Jul 16, 2020
meta/runtime.yml Show resolved Hide resolved
meta/runtime.yml Outdated Show resolved Hide resolved
changelogs/fragments/firewalld_migration.yml Outdated Show resolved Hide resolved
maxamillion and others added 3 commits July 16, 2020 11:06
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Adam Miller <admiller@redhat.com>
meta/runtime.yml Outdated Show resolved Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Collaborator

Failures are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request has_issue integration tests/integration module_utils module_utils module module plugins plugin (any type) system tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants