-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate firewalld to ansible.posix #623
migrate firewalld to ansible.posix #623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need a changelog fragment (see https://github.com/ansible-collections/community.general/pull/622/files#diff-4c118fa945bad8fa5c56e82cd92785b3 for an example).
recheck |
This still needs a changelog fragment. @maxamillion when will ansible.posix be released with the firewalld module in it? |
@felixfontein +1 definitely need a changelog fragment, thank you! I can release the |
@maxamillion I'm not sure how we want to proceed with moving content after ansible_builtin_runtime.yml is frozen. I think we'll have to discuss this at the community meeting first (maybe even next week, since gundalow is away this week). |
@felixfontein fair point, worst case scenario I'll maintain both places for the overlap timeframe. I'd prefer not to but if necessary, that's always an option. |
For posterity: because the RC1 is delayed it was approved to do the migration now |
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
1c916be
to
cd273ef
Compare
Signed-off-by: Adam Miller <admiller@redhat.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Adam Miller <admiller@redhat.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Failures are unrelated. |
Signed-off-by: Adam Miller admiller@redhat.com
SUMMARY
migrate firewalld to ansible.posix
moved to ansible-collections/ansible.posix#68
ISSUE TYPE
COMPONENT NAME
firewalld