Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix even more tests #69

Merged
merged 6 commits into from
Mar 30, 2020

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fix some issues from #68.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

CI

@felixfontein felixfontein changed the title [WIP] Fix even more tests Fix even more tests Mar 30, 2020
@felixfontein felixfontein mentioned this pull request Mar 30, 2020
@felixfontein
Copy link
Collaborator Author

The meraki module_utils which is supposedly tested by the unit test isn't in this collection.

@felixfontein felixfontein requested a review from gundalow March 30, 2020 07:16
@@ -20,7 +20,7 @@

- name: Test random_mac filter bad argument value
debug:
var: "'dummy' | community.generalrandom_mac"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that was my typo, thanks for fixing.

@gundalow
Copy link
Contributor

Thanks!

@gundalow gundalow merged commit 14731bf into ansible-collections:master Mar 30, 2020
@felixfontein felixfontein deleted the even-more-tests branch March 30, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants