Fix netapp modules #76
Conversation
|
The CI failures are unrelated to this change. |
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| short_description: Manage NetApp cDOT aggregates. | |||
| extends_documentation_fragment: | |||
| - community.general.netapp.ontap | |||
| - community.general._netapp.ontap | |||
|
|
|||
There was a problem hiding this comment.
This module is deprecated. It is actually _na_cdot_aggregate.py.
I would rather have it deleted, as it is introducing confusion.
There was a problem hiding this comment.
The _ mechanism for modules is no longer supported in collections. Instead, metadata (and once ansible/ansible#67684 has been merged, metadata parsed by that) is used.
The module has been marked as deprecated with a removed_in_version of 2.11, i.e. it should stay until Ansible 2.11 is released.
| @@ -19,7 +19,7 @@ | |||
| alternative: Use M(na_ontap_info) instead. | |||
| author: Piotr Olczak (@dprts) <polczak@redhat.com> | |||
| extends_documentation_fragment: | |||
| - netapp.ontap.netapp.na_ontap | |||
| - community.general._netapp.na_ontap | |||
There was a problem hiding this comment.
This module has been renamed to na_ontap_info (by RedHat). How would an end user know that this module is deprecated.
There was a problem hiding this comment.
Because of the deprecation warning printed whenever it is used.
| @@ -21,7 +21,7 @@ | |||
| alternative: please use M(na_elementsw_account) | |||
| short_description: Manage SolidFire accounts | |||
| extends_documentation_fragment: | |||
| - community.general.netapp.solidfire | |||
There was a problem hiding this comment.
this module has been deprecated for 2 years.
I would rather not include it, as it is creating confusion.
There was a problem hiding this comment.
It has also been marked as deprecated with removal in Ansible 2.11. So it has to stay a bit longer, and will eventually be removed and replaced with a tombstone.
|
@lonico do you mind if this gets merged? The modules are in this repository right now, and even if they are moved somewhere else, these changes have to be made. I don't see any reason to delay them further, as this has been breaking CI for quite some time already. |
|
Sorry about getting to this late. For the netapp_e* modules are written by our e-series team (https://github.com/netappeseries/santricity) For there collection they are going with ansible_collections.netapp_eseries.santricity |
|
Ok, I've updated the PR to remove all netapp_e_* modules from this collection. Please note that https://github.com/ansible/ansible/blob/devel/lib/ansible/config/routing.yml and https://github.com/ansible/ansible/blob/devel/.github/BOTMETA.yml need to be updated for the new locations of the modules, otherwise playbooks which worked in Ansible 2.9 will stop working in Ansible 2.10 since Ansible 2.10 won't be able to find these modules anymore. |
When testing dashboad payload between the test resulted in reverted values leading to the dashboard not being updated when it should. Closes: ansible-collections#76
SUMMARY
Fixes the netapp modules to use its own copy of module_utils and docs fragment. These can be removed eventually.
Both module_utils and docs fragment are marked as deprecated (Python convention) by prepending
_.ISSUE TYPE
COMPONENT NAME
netapp modules