Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7676/a599afa3 backport][stable-8] lvol: Change pvs argument type to list (of str) #7681

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Dec 4, 2023

This is a backport of PR #7676 as merged into main (a599afa).

SUMMARY

I've modified the pvs argument's type to list (of str) of the lvol module to provide a consistent interface with the lvg module.
I consider this as a minor change as the current playbooks are not affected by this change due to the nature of the list type handling in the core AnsibleModule.

Fixes #7504

ISSUE TYPE
  • Bugfix Pull Request
  • Refactoring Pull Request
COMPONENT NAME

lvol

* lvol: Change ``pvs`` argument type to list (of str)

* Add changelog fragment

* Apply review suggestions

(cherry picked from commit a599afa)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Dec 4, 2023
@felixfontein felixfontein merged commit 410101a into stable-8 Dec 4, 2023
124 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-8/a599afa384b4894cddbf8c0c7a1bbea181af6c08/pr-7676 branch December 4, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants