Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interfaces_file: re.escape() old value #873

Merged
merged 1 commit into from
Sep 8, 2020
Merged

interfaces_file: re.escape() old value #873

merged 1 commit into from
Sep 8, 2020

Conversation

jplitza
Copy link
Contributor

@jplitza jplitza commented Sep 8, 2020

SUMMARY

Fixes #777

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

interfaces_file

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @MorrisA @bcoca @d-little @flynn1973 @gforster @hryamzik @kairoaraujo @marvin-sinister @mator @molekuul @obourdon @ramooncamacho @wtcross
click here for bot help

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review system labels Sep 8, 2020
felixfontein
felixfontein reviewed Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that, LGTM.

changelogs/fragments/777-interfaces_file-re-escape.yml Outdated Show resolved Hide resolved
@jplitza jplitza mentioned this pull request Sep 8, 2020
Closed
@mator
Copy link
Contributor

mator commented Sep 8, 2020

works for me...
shipit

@felixfontein felixfontein merged commit eb24b57 into ansible-collections:main Sep 8, 2020
@felixfontein
Copy link
Collaborator

@jplitza thanks a lot for fixing this!
@mator thanks for reviewing!

Does anyone of you want to backport this to ansible/ansible's stable-2.9 branch (so it gets included in a 2.9.x release)? If not I can also do it.

@jplitza jplitza deleted the issue-777 branch September 12, 2020 12:14
@jplitza jplitza mentioned this pull request Sep 12, 2020
Merged
felixfontein added a commit to felixfontein/ansible that referenced this pull request Sep 15, 2020
@felixfontein
Backport of eb24b5707ee48c3186f771e3d5b1f04c9fba339f from community.g…
99aeec7 
…eneral (ansible-collections/community.general#873).
@felixfontein felixfontein mentioned this pull request Sep 15, 2020
Merged
@felixfontein
Copy link
Collaborator

I created the backport to ansible/ansible's stable-2.9: ansible/ansible#71766

relrod pushed a commit to ansible/ansible that referenced this pull request Sep 27, 2020
@felixfontein
interfaces_file: re.escape() old value
f35fed4 
Backport of eb24b5707ee48c3186f771e3d5b1f04c9fba339f from community.general (ansible-collections/community.general#873). (#71766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review has_issue module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interfaces_file: Regular expression characters not escaped
4 participants
@jplitza @ansibullbot @mator @felixfontein