More resilient brew formulae name handling #9665
Open
+125
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
check-before-release
russoz
reviewed
Feb 6, 2025
There was a problem hiding this comment.
hi @UnknownPlatypus thanks for the PR!
I spotted a typo and left a question on the tests, other than that it LGTM
felixfontein
reviewed
Feb 9, 2025
|
I'll merge somewhen tomorrow if nobody objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #9641, Review by commit is advised
There are actually 2 issues:
One with the uppercase letters.
Apparently, brew normalize everything to lowercase. For ex:
$ brew info --json=v2 TheZoraiz/ascii-image-converter/ascii-image-converter { "formulae": [ { "name": "ascii-image-converter", "full_name": "thezoraiz/ascii-image-converter/ascii-image-converter", "tap": "thezoraiz/ascii-image-converter", ...The other is with the handling of tap with no equivalent in brew registry
ie you cannot do
brew install ascii-image-converterif you didn't tapthezoraiz/ascii-image-converterbefore.We previously missed this case in tests because we used
hashicorp/tap/terraformbut there is a regularterraformpackage tooISSUE TYPE
COMPONENT NAME
homebrew