Use PHP array form encoding when sending multiple authorized_key
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP required arrays to contains `[]` in the parameters key. Without the brackets, only a single value will be parsed. See as example:
$ php -r "echo http_build_query(array('authorized_key' => array('key1', 'key2', 'key3')));"
authorized_key%5B0%5D=key1&authorized_key%5B1%5D=key2&authorized_key%5B2%5D=key3%
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 34 34
Lines 2427 2427
Branches 274 274
=======================================
Hits 2384 2384
Misses 20 20
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
changelogs/fragments/fix-authorized_key-php-array-form-encoding.yml
Outdated
Show resolved
Hide resolved
| @@ -404,7 +404,7 @@ def main(): | |||
| if should is None: | |||
| continue | |||
| # unfold the return object for the idempotence check to work correctly | |||
| has = existing.get(data_key) | |||
| has = existing.get(result_key) | |||
There was a problem hiding this comment.
While reviewing I noticed that it should be using result_key here, not data_key - this so far didn't make a difference since the values were equal, but now they're not :)
felixfontein
approved these changes
Jun 17, 2024
|
@jooola thanks for fixing this! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 17, 2024
) * Use PHP array form encoding when sending multiple `authorized_key` PHP required arrays to contains `[]` in the parameters key. Without the brackets, only a single value will be parsed. See as example: $ php -r "echo http_build_query(array('authorized_key' => array('key1', 'key2', 'key3')));" authorized_key%5B0%5D=key1&authorized_key%5B1%5D=key2&authorized_key%5B2%5D=key3% * fix changelog * test: fix unit tests * Update changelog fragment. * Use the correct key for idempotency. --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 2c3977d)
|
Awesome, I appreciate the quick response and release 🫶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
PHP required arrays to contains
[]in the parameters key. Without the brackets, only a single value will be parsed. See as example:More about this array syntax: https://www.php.net/manual/en/function.parse-str.php#76792
Closes #112
ISSUE TYPE
COMPONENT NAME
community.hrobot.boot