Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename whitelist_hos → allowlist_hos #15

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

My plan is to start deprecating the old names in version 2.0.0, and remove them in 3.0.0, to give users enough time to migrate to the new names. The API itself will probably stick to the old name...

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

firewall
firewall_info

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #15 (31e7a94) into main (3a07095) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   98.03%   98.05%   +0.02%     
==========================================
  Files          15       15              
  Lines        1066     1079      +13     
  Branches       99       99              
==========================================
+ Hits         1045     1058      +13     
  Misses         13       13              
  Partials        8        8              
Impacted Files Coverage Δ
plugins/modules/firewall.py 96.73% <100.00%> (+0.08%) ⬆️
plugins/modules/firewall_info.py 93.33% <100.00%> (+0.22%) ⬆️
tests/unit/plugins/modules/test_firewall.py 100.00% <100.00%> (ø)
tests/unit/plugins/modules/test_firewall_info.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a07095...31e7a94. Read the comment docs.

@felixfontein felixfontein merged commit 9474dda into ansible-collections:main Jun 14, 2021
@felixfontein felixfontein deleted the allowlist branch June 14, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant