Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ansible.module_utils._text by ansible.module_utils.common.text.converters #18

Merged
merged 1 commit into from
Jun 26, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

While the private API ansible.module_utils._text was the default place to get to_text, to_bytes and to_native for a long time, at least since Ansible 2.9 there's a non-private alternative: ansible.module_utils.common.text.converters. So let's use it :)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

various plugins

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #18 (2f39da1) into main (3469e65) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          15       15           
  Lines        1107     1107           
  Branches      101      101           
=======================================
  Hits         1086     1086           
  Misses         13       13           
  Partials        8        8           
Impacted Files Coverage Δ
plugins/modules/firewall.py 96.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3469e65...2f39da1. Read the comment docs.

@felixfontein felixfontein merged commit ecaf649 into ansible-collections:main Jun 26, 2021
@felixfontein felixfontein deleted the text-conv branch June 26, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant