Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility to fetch_url change in ansible-core devel #30

Merged

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

There was a breaking change in ansible-core's devel branch (see ansible/ansible#76314 for details). This makes this collection's code work with the latest version, and all older ansible-core/ansible-base/Ansible 2.9 versions.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

robot module utils

@felixfontein
Copy link
Collaborator Author

Needs ansible-collections/community.internal_test_tools#52 to be merged first.

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #30 (7ffaafd) into main (3937f5b) will decrease coverage by 0.10%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   99.02%   98.91%   -0.11%     
==========================================
  Files          29       29              
  Lines        1840     1843       +3     
  Branches      158      159       +1     
==========================================
+ Hits         1822     1823       +1     
- Misses         11       12       +1     
- Partials        7        8       +1     
Impacted Files Coverage Δ
plugins/module_utils/robot.py 97.67% <60.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3937f5b...7ffaafd. Read the comment docs.

@felixfontein felixfontein merged commit 94a76d0 into ansible-collections:main Nov 17, 2021
@felixfontein felixfontein deleted the fix-fetch_url-calls branch November 17, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant